Hi, Thanks to Lei and Haonan’s review and approval, the refactor PR [1] has been merged into master.
This may result in conflicts in other recent PRs, so when you meet conflicts, I’ll be very glad to help you resolve them. : ) If you have any suggestions and ideas about this refactor in the future, please discuss with me and I will be responsible for it. [1] https://github.com/apache/incubator-iotdb/pull/530 <https://github.com/apache/incubator-iotdb/pull/530> Best, ----------------------------------- Zesong Sun School of Software, Tsinghua University 孙泽嵩 清华大学 软件学院 > 2019年11月7日 17:01，孙泽嵩 <[email protected]> 写道： > > Hi, > > I’m currently working on refactoring db.exception by adding different error > codes to all exceptions. When an exception is caught and a higher-level > exception is thrown, the error code will keep and pass, so that users will > know the detailed error reason. > > Besides, I also create a base exception "ProcessException", which is extended > by all exceptions, and delete previous “ProcessorException” for it's > meaningless and over-general. > > Here is my PR [1] . And in the JIRA issue comments area [2], I have uploaded > a UML figure for the exception classes. If you have any questions and > suggestions, please discuss with me. > > [1] https://github.com/apache/incubator-iotdb/pull/530 > <https://github.com/apache/incubator-iotdb/pull/530> > [2] > https://issues.apache.org/jira/browse/IOTDB-295?focusedCommentId=16968950&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16968950 > > <https://issues.apache.org/jira/browse/IOTDB-295?focusedCommentId=16968950&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16968950> > > > Best, > ----------------------------------- > Zesong Sun > School of Software, Tsinghua University > > 孙泽嵩 > 清华大学 软件学院 > >> 2019年11月7日 13:14，Zesong Sun (Jira) <[email protected] >> <mailto:[email protected]>> 写道： >> >> Zesong Sun created IOTDB-295: >> -------------------------------- >> >> Summary: Refactor db.exception >> Key: IOTDB-295 >> URL: https://issues.apache.org/jira/browse/IOTDB-295 >> <https://issues.apache.org/jira/browse/IOTDB-295> >> Project: Apache IoTDB >> Issue Type: Improvement >> Reporter: Zesong Sun >> Fix For: 0.9.0-SNAPSHOT >> >> >> Refactor db.exception: >> * Extract uniform message into exception classes >> * Create base exception "ProcessException", which is extended by all >> exceptions >> * Add different error codes to all exceptions. When an exception is caught >> and a higher-level exception is thrown, the error code will keep and pass >> (so that users will know the detailed error reason) >> * Refactor packages under db.exception >> >> >> >> -- >> This message was sent by Atlassian Jira >> (v8.3.4#803005) >
