Sorry the PR link is [1]. [1] https://github.com/apache/incubator-iotdb/pull/610
Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Xiangdong Huang <saint...@gmail.com> 于2019年12月1日周日 下午1:45写道： > Hi, > > Considering we packed some incorrect files in the last release (RC1 to > RC4), I think writing an assembly.xml file for generating the > source-release.zip is a good way to avoid that. > > What is more, it is very helpful when we switch different branches for > releasing. for example, in v0.9.0, there is a module called session, which > does not exist in 0.8.0. So, if I switch the branch from 0.9 to 0.8 (or > rel/0.8) for a minor version releasing (e.g., 0.8.2), I have to remove the > session folder manually. If I forgot that, a dirty source-release.zip is > generated. But if we have an assembly.xml, it will avoid that. > > I have written the source-assembly.xml now in PR [1]. The assembly file > looks ugly because we have to declare the files one by one. (I tried the > <moduleSet> tag, which is more convenient. But because our > module.artifactId != module.folder name, there is some issues that I can > not solve. Finally I gave up using <moduleSet> tag). > > If the PR is accepted, then for all contributors please notice that: > > (1) If you add new source files into a src/ docs/ license folder, it is ok. > (2) If you add a new module, create a new folder, or write a plain text > file under the project's (or a module's) root directory, you have to > maintain the source-assembly.xml file.. Otherwise the new added files will > not be packed into source-release.zip. > > Hope in this way, we can no longer get dirty source-release.zip files. > > [1] > Best, > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 >
