Thanks Xiangdong, good tip for everyone. - Xin
Xiangdong Huang <saint...@gmail.com> 于2020年4月8日周三 下午2:36写道： > Hi, > > I notice there were several PRs that did not pass the Travis-CI test but be > merged... > > Maybe some errors can be ignored, but please pay attention to each error > that Travis-CI reports... > > If you really want to merge a PR that is not passed by Travis-CI, please > leave a message on the PR to let others know. And, I'd like to share a > screenshot [1] to you and the sentence: "*You should only continue if you > are sure of what you are doing*"... > > Besides, I think we need to keep the rule that a PR can be merged only > after at least one Committer approved. > > [1] > > https://www.howtogeek.com/wp-content/uploads/2013/03/firefox-about-config-warning.png > > Best, > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > -- Thanks, Xin
