Hi Xiangdong,

thanks for your work.
Indeed your module looks good now (init.py everywhere and such things).

I will also add the Support for python-testcontainers in the official code as 
ist quite neat for tests.

Julian

Am 26.11.20, 11:09 schrieb "Xiangdong Huang" <saint...@gmail.com>:

    By the way, tests are not contained in the PR.

    Best,
    -----------------------------------
    Xiangdong Huang
    School of Software, Tsinghua University

     黄向东
    清华大学 软件学院


    Xiangdong Huang <saint...@gmail.com> 于2020年11月26日周四 下午6:07写道:

    > Hi Julian,
    >
    > Thanks!
    > Actually, I occur some problems when release iotdb-py-client 0.11.0 to
    > pypi.
    >
    > After checking your modifications and under the help of Kaifeng Xue,
    > I think I fixed them. see PR[1] and [2].
    >
    > (I uniform the package name as `iotdb`)
    >
    > [1] https://github.com/apache/iotdb/pull/2127
    > [2] https://github.com/apache/iotdb/pull/2128
    >
    > Best,
    > -----------------------------------
    > Xiangdong Huang
    > School of Software, Tsinghua University
    >
    >  黄向东
    > 清华大学 软件学院
    >
    >
    > Julian Feinauer <j.feina...@pragmaticminds.de> 于2020年11月26日周四 上午3:54写道:
    >
    >> I would like to merge that soon into iotdb.
    >>
    >> But yes, generally it should be.
    >>
    >> Julian
    >>
    >> Holen Sie sich Outlook für Android<https://aka.ms/ghei36>
    >>
    >> ________________________________
    >> From: Xiangdong Huang <saint...@gmail.com>
    >> Sent: Wednesday, November 25, 2020 4:10:30 PM
    >> To: dev <dev@iotdb.apache.org>
    >> Subject: Re: Update for Python Lib for 0.10.1
    >>
    >> Hi,
    >>
    >> Is that possible to enable it on Github Action?
    >>
    >> -----------------------------------
    >> Xiangdong Huang
    >> School of Software, Tsinghua University
    >>
    >>  黄向东
    >> 清华大学 软件学院
    >>
    >>
    >> Giorgio Zoppi <giorgio.zo...@gmail.com> 于2020年11月25日周三 下午9:33写道:
    >>
    >> > Hey Julian,
    >> > do you have as well a github to share?
    >> > Best Regards,
    >> > Giorgio
    >> >
    >>
    >

Reply via email to