Hello, also for the quality..it would be nice use https://coveralls.io/ since it's a new brand software, it's free for opensource. So we could see the coverage and tests when it's needed. BR, Giorgio.
Il giorno lun 15 nov 2021 alle ore 06:57 Xiangdong Huang <[email protected]> ha scritto: > Hi, > > Unfortunately, even if we can debase the code quality temporarily, you > have to remove Chinese comments at first. > The lowest bar is everyone can download and compile the codes. > > And I suggest inviting @Julian Feinauer and his mates to review > quickly, rather than skip the code review. > > During this period, you can set up the CI process. > > Best, > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > > 还有多少时间 <[email protected]> 于2021年11月15日周一 上午11:29写道： > > > > Hi Giprogio、XiangDong Huang、JiaLin Qiao > > > > > > Because of the large amount of code, it is difficult for everyone to > review. Could you please combine the current PR first? During this period, > we will revise the questions raised by everyone and then propose the new PR. > > > > > > Qiang Zheng > > CISDI > > > > > > ------------------ 原始邮件 ------------------ > > 发件人: > "dev" > < > [email protected]>; > > 发送时间: 2021年11月14日(星期天) 凌晨5:00 > > 收件人: "dev"<[email protected]>; > > > > 主题: Re: We are very excited to announce the upcoming release of > IoTDB-WorkBench 1.1.0 > > > > > > > > Hello, > > as side point things like: > > @PostMapping("/storageGroups") > > @ApiOperation("新增或修改存储组") > > public BaseVO saveStorageGroup > > > > > > You're publishing for a world wide audience so ...the chinese should > > disappear for matters of readability. > -- Life is a chess game - Anonymous.
