Thanks, Jialin. Your review does me a lot of favor.

Glad to see anyone's feedback.

Jialin Qiao <qiaojia...@apache.org> 于2021年11月23日周二 下午8:20写道:

> Hi,
> Yes, the catching-up work is heavy...
> Looking forward to merging this PR :)
> —————————————————
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
>
> Junqing Wang <irvine0...@gmail.com> 于2021年11月23日周二 下午7:56写道:
>
> > Hi,
> >
> > As catching up with the master branch is continuous and massive, all
> > refactor work can be split into two temporary phases.
> >
> > Phase 1,
> >
> >    - This PR should be reviewed.
> >    - All tests should be annotated with the LocalStandaloneTest category.
> >    - All these LocalStandaloneTest should be passed.
> >    - No-brain tutorials should be done. (It will be sent tomorrow at the
> >    latest.)
> >
> > The milestone of phase 1 is this PR is merged.
> >
> > Phase 2,
> >
> >    - All tests should be appropriately annotated with the ClusterTest
> >    category.
> >    - All these ClusterTest should be passed.
> >    - New IT should be followed by No-brain tutorials.
> >
> > The milestone of phase 2 is all ITs are passed.
> >
> > I think phase 1 is done this week is appropriate. And phase 2 is not so
> > urgent.
> >
> > The above is already mentioned in the #integration-test channel of slack
> in
> > Chinese. I will sync the progress in slack.
> >
> > Jialin Qiao <qiaojia...@apache.org> 于2021年11月23日周二 下午7:12写道:
> >
> > > Hi,
> > >
> > > This PR refactors the IT framework:
> > > https://github.com/apache/iotdb/pull/4371
> > >
> > > It will help us test the cluster, please pay attention and review.
> > >
> > > Thanks,
> > > —————————————————
> > > Jialin Qiao
> > > School of Software, Tsinghua University
> > >
> > > 乔嘉林
> > > 清华大学 软件学院
> > >
> >
>

Reply via email to