+1 Best, Haonan Hou
> On May 26, 2022, at 10:07 PM, Jialin Qiao <[email protected]> wrote: > > Hi, > > We need to support specifying no sg. How about: > > FLUSH [(<sg>,)*<sg>] [ON (LOCAL|CLUSTER)] > > Some examples: > > flush root.sg1【flush root.sg1 on current datanode】 > flush root.sg1 on local 【flush root.sg1 on current datanode】 > flush root.sg1 on cluster 【flush root.sg1 on all datanodes】 > flush on cluster 【flush all sgs on all datanodes】 > flush on local 【flush all sgs on current datanode】 > flush 【flush all sgs on current datanode】 > > In the standalone version, "on cluster" will be rejected. > > Thanks, > ————————————————— > Jialin Qiao > Apache IoTDB PMC > > > Xiangdong Huang <[email protected]> 于2022年5月23日周一 21:25写道： > >> OK... SQL should look like a complete sentence.. So, how about "FLUSH >> (<sg>,)*<sg> [ON LOCAL, CLUSTER]" >> If [ON LOCAL] is omitted, then it just flushes locally. >> >> ----------------------------------- >> Xiangdong Huang >> School of Software, Tsinghua University >> >> 黄向东 >> 清华大学 软件学院 >> >> >> Eric Pai <[email protected]> 于2022年5月23日周一 11:53写道： >> >>> As we want to define the SQL grammar, it's not a good choice to use Unix >>> command line style syntax. >>> >>> 在 2022/5/23 11:42，“Xiangdong Huang”<[email protected]> 写入: >>> >>> how about: flush [<sg>, <sg>] [--all-nodes] [-node <ip>] >>> >>> omitting [<sg>] means flush all sgs. >>> -- all-nodes means flush on each nodes >>> -node <ip> means flush on the given node >>> omitting [-node <ip>] and [--all-nodes] equals [-node 127.0.0.1] >>> --all-nodes and -node are mutually exclusive >>> >>> Best, >>> ----------------------------------- >>> Xiangdong Huang >>> School of Software, Tsinghua University >>> >>> 黄向东 >>> 清华大学 软件学院 >>> >>> >>> Eric Pai <[email protected]> 于2022年5月23日周一 11:27写道： >>> >>>> +1. It's not necessary to give 2 different syntax but with same >>> meaning. >>>> Just define the most suitable one. >>>> >>>> 在 2022/5/23 11:22，“Haonan Hou”<[email protected]> 写入: >>>> >>>> Hi, >>>> >>>> +1 for `FLUSH ALL` syntax. >>>> >>>> `FLUSH` and `FLUSH sg` are the existing syntax of the current >>>> standalone version. >>>> If we execute `FLUSH ALL` on standalone IoTDB, it can be equals >>> to >>>> `Flush` command. >>>> `flush cluster` sounds meaningless for standalone IoTDB. >>>> >>>> Best, >>>> Haonan Hou >>>> >>>>> On May 23, 2022, at 11:07 AM, Jialin Qiao < >>> [email protected]> >>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> Flush is a frequently used command in IoTDB, which flushes >>> memtable >>>> into >>>>> disk and closes all tsfiles. >>>>> >>>>> In the new cluster, we need to redefine this function [1]. >>>>> >>>>> * flush: flushing current datanode >>>>> >>>>> * flush all/cluster: flushing all datanodes >>>>> >>>>> * flush sg: flush all DataRegions of a storage group >>>>> >>>>> >>>>> What do you think? >>>>> >>>>> [1] >>>> >>> >> https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FIOTDB-3099&data=05%7C01%7C%7C9bf11e7a5a2c4b8270f708da3c6e3868%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637888741347695139%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UY0gbvyZNox8WctT7N0yK6hz71NiWtZh%2BtW18TO4uOw%3D&reserved=0 >>>>> >>>>> ————————————————— >>>>> Jialin Qiao >>>>> Apache IoTDB PMC >>>> >>>> >>>> >>> >>> >> >
