+1
Thanks! Chao Wang BONC ltd [email protected] On 10/22/2022 15:15，Jialin Qiao<[email protected]> wrote： Hi, In the new distribution folder, we move all these scripts into sbin folder. Move the remove-datanode.sh into tools is also ok, we could rename it to node-tool (support removing confignode and datanode). node-tool.sh -r nodeid What do you think? Thanks, ————————————————— Jialin Qiao Apache IoTDB PMC Chao Wang <[email protected]> 于2022年10月22日周六 15:07写道： Hi, yes, it's a tool now, sorry for my mistake. And, move it to tools directory seems more suitable. Thanks! Chao Wang BONC ltd [email protected] On 10/22/2022 14:49，Jialin Qiao<[email protected]> wrote： Hi, If I don't misremember, the remove-datanode.sh is indeed a tool with which we can remove any datanode in the cluster... Thanks, ————————————————— Jialin Qiao Apache IoTDB PMC Chao Wang <[email protected]> 于2022年10月22日周六 14:43写道： Hi, I think "start-datanode.sh -r" is ok, means start with remove mode. The remove-datanode.sh seems more like a tool with which we can remove any datanode in the cluster. Thanks! Chao Wang BONC ltd [email protected] On 10/22/2022 11:45，Jialin Qiao<[email protected]> wrote： Hi, If we use one script, what should we naming it, start-datanode.sh or others? Just feel "start-datanode.sh -r" look strange, user may also need to read the UserGuide to find the removing function. If we put remove-datanode.sh in sbin, users could find it directly under sbin. Thanks, ————————————————— Jialin Qiao Apache IoTDB PMC Chao Wang <[email protected]> 于2022年10月22日周六 10:56写道： And， why do we need remove-datanode.sh and remove-confignode.sh scripts? I think those two scripts need to be merged into start-datanode.sh and start-confignode.sh, after all, they only have one parameter diffierence. Thanks! Chao Wang BONC ltd [email protected] On 10/21/2022 17:52，Chao Wang<[email protected]> wrote： +1 Thanks! Chao Wang BONC ltd [email protected] On 10/21/2022 09:15，Houliang Qi<[email protected]> wrote： +1 Thanks, --------------------------------------- Houliang Qi BONC, Ltd ---- Replied Message ---- | From | Jialin Qiao<[email protected]> | | Date | 10/20/2022 23:56 | | To | <[email protected]> | | Subject | Re: The structure of distribution | +1 ————————————————— Jialin Qiao Apache IoTDB PMC Haonan Hou <[email protected]> 于2022年10月20日周四 18:32写道： Hi all, We will release v1.0 in the nearly future, it's time to decide the final version of distribution structure. After investigate other projects, like Hadoop and Spark. I think it will be better that remove the confignode and datanode folder, and combine their script and configuration files into the conf and sbin under IOTDB_HOME. The design document is in [1]. I also submitted a PR[2] to make such changes, in where you can find the screenshot of new structure. [1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe [2] https://github.com/apache/iotdb/pull/7672 Best, ————————— Haonan Hou
