Good, looking forward your update about it. :) Best, Haonan
On 2023/08/17 07:08:39 Christofer Dutz wrote: > Yeah we sort of do... But the content of the artifact is going to contain two > xml files. But it's going to simplify things a lot. > > Chris > > Gesendet von Outlook für Android<https://aka.ms/AAb9ysg> > ________________________________ > From: Haonan Hou <[email protected]> > Sent: Thursday, August 17, 2023 3:54:43 AM > To: [email protected] <[email protected]> > Subject: Re: Deploying the iotdb-tools-thrift artifacts ... > > I have one more question. If we are going to release the iotdb-tools-thift > library, do we need to a vote for it? > > Haonan > > On 2023/08/16 12:19:44 Christofer Dutz wrote: > > Hi all, > > > > > > Today I was made aware that there were issues with the thrift compiler > > artifacts that I switched to using in my last refactoring. > > > > When having a look in Nexus I could see that the libraries staged there > > weren’t the ones I put there as they had a different structure, were no > > longer containing statically linked thrift executables, didn’t have > > libraries and includes in them. So someone must have deployed them but must > > have used an old state of the master branch. > > > > But we solved the problem, why they keep on disappearing :-/ > > > > When deploying all 5 artifacts, we run a maven build 5 times and deploy 5 > > snapshots of the same artifact. On Saturday a cleanup job removes all but > > the newest 3 snapshots of each artifact. > > > > So if we want to keep on using the SNAPSHOT versions, we will have to > > re-reploy them every Saturday. > > > > I would however encourage us to do something different: > > > > Move the “tools” part into the > > https://github.com/apache/iotdb-bin-resources repo and release the > > iotdb-tools-thift library (I’d recommend simply using the thrift version > > instead of the iotdb version as the library actually has absolutely nothing > > to do with iotdb and is just a compilation of thrift packaged in a way that > > we can use it. > > Then this problem would be gone forever and we’d only need to re-do it if > > we switch to a new Thrift version. > > > > What do you think? > > > > Chris > > > > >
