+1 (binding)
Chris
PS: However, we have a bit of homework to do … see in my validation results.
[OK] Download all staged artifacts under the url specified in the release vote
email.
[OK] Verify the signature is correct.
* Checked all artifacts
[OK] Check if the signature references an Apache email address.
* Checked all artifacts
[OK] Verify the SHA512 hashes.
* Checked all artifacts
[OK] Unzip the archive.
[OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in
the extracted source bundle.
[MINOR] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in
the extracted source bundle.
* LICENSE:
* Possibly Murmur128Hash.java can be used from the original
commons-collections as it seems the PR83 has been merged.
* The section about the code modified from the Apache HBase project
claims to be copyrighted by Micheal Burman (I guess that’s a copy from the
above section)
* NOTICE
* The notice references 2018-2022, but should 2018-2023
[MINOR] Run RAT externally to ensure there are no surprises.
* It seems that I am unable to run rat against the sources-zip but need to
run it against the unpacked directory.
* It seems
apache-iotdb-1.2.0/example/mqtt-customize/src/main/resources/META-INF/services/org.apache.iotdb.db.protocol.mqtt.PayloadFormatter
doesn’t have an Apache header but could easily have one.
* It would be cool if we could build the following as part of the build:
*
apache-iotdb-1.2.0/integration-test/src/test/resources/TriggerFireTimesCounter.jar
*
apache-iotdb-1.2.0/integration-test/src/test/resources/trigger-example.jar
* apache-iotdb-1.2.0/integration-test/src/test/resources/udf-example.jar
[MINOR] Search for SNAPSHOT references
* We’re referencing Ratis in version 2.5.2-7451d86-SNAPSHOT … this could be
a problem as soon as it is released, as then all SNAPSHOT versions will be
deleted, and this dependency can no longer be resolved.
* The module “integration-test” was not part of the release build, so it is
referencing “1.2.0-SNAPSHOT”. Be sure to use all the “with-xyz” profiles to
include all modules in the release build (The following profiles are needed for
the current master branch: with-cpp, with-grafana-plugin,
with-integration-tests)
* The module “spark-iotdb-connector” was not part of the release build, so
it’s referencing “1.2.0-SNAPSHOT”.
* The module “testcontainer” was not part of the release build, so it’s
referencing “1.2.0-SNAPSHOT”.
[MINOR] Search for Copyright references, and if they are in headers, make sure
these files containing them are mentioned in the LICENSE file.
* The following files contain Copyright information without being listed in
the LICENSE file:
* “Copyright © 2021 iotdb-quality developer group
([email protected]<mailto:[email protected]>)” (No idea
where this came from and what license it was under, willing to treat is as
MINOR this time, but on the next release I’ll consider it a NOT OK)
*
apache-iotdb-1.2.0/library-udf/src/main/java/org/apache/iotdb/library/series/UDTFConsecutiveSequences.java
*
apache-iotdb-1.2.0/library-udf/src/main/java/org/apache/iotdb/library/series/UDTFConsecutiveWindows.java
*
apache-iotdb-1.2.0/library-udf/src/main/java/org/apache/iotdb/library/series/util/ConsecutiveUtil.java
* “Copyright: 2022- Panagiotis Liakos, Katia Papakonstantinopoulou and
Yannis Kotidis” (Is Apache 2.0, so MINOR)
*
apache-iotdb-1.2.0/tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/DoublePrecisionChimpDecoder.java
*
apache-iotdb-1.2.0/tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/IntChimpDecoder.java
*
apache-iotdb-1.2.0/tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/LongChimpDecoder.java
*
apache-iotdb-1.2.0/tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/SinglePrecisionChimpDecoder.java
*
apache-iotdb-1.2.0/tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/DoublePrecisionChimpEncoder.java
*
apache-iotdb-1.2.0/tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/IntChimpEncoder.java
*
apache-iotdb-1.2.0/tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/LongChimpEncoder.java
*
apache-iotdb-1.2.0/tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/SinglePrecisionChimpEncoder.java
[OK] Build the project according to the information in the README.md file.
Von: Gaofei Cao <[email protected]>
Datum: Donnerstag, 7. September 2023 um 05:03
An: [email protected] <[email protected]>
Betreff: Re: [VOTE] Apache IoTDB 1.2.0 RC2 release
Hi,
+1 (binding)
The source release:
apache headers [ok]
signatures and hashes [ok]
LICENSE and NOTICE [ok]
no jar files [ok]
could compile from source: ./mvnw.sh clean install [ok]
The binary distribution:
version number in CLI [ok]
signatures and hashes [ok]
start in mac, jdk17 [ok]
statements executed successfully: [ok]
SET STORAGE GROUP TO root.turbine;
CREATE TIMESERIES root.turbine.d1.s0 WITH DATATYPE=DOUBLE, ENCODING=RLE;
insert into root.turbine.d1(timestamp,s0) values(1,1);
insert into root.turbine.d1(timestamp,s0) values(2,2);
insert into root.turbine.d1(timestamp,s0) values(3,3);
select * from root.**;
Best,
Gaofei Cao
