At apache every line of coffee needs to be traced back to a committer (ideally one we have an icla on file) so as far as I know only on very few Jenkins boxes are committed possible in some edge cases (such as staging a generated website)
I do think I see your argument. I'm one of the people who run the maven build before committing. If someone doesn't, I see that could be a problem. However we could simply run "mvn spottless:check" on any ci before sound the real build. Chris Gesendet von Outlook für Android<https://aka.ms/AAb9ysg> ________________________________ From: liyuheng <liyuheng55...@126.com> Sent: Wednesday, August 21, 2024 5:20:12 AM To: dev@iotdb.apache.org <dev@iotdb.apache.org> Subject: Re: [DISCUSS] How about running spotless:apply instead of spotless:check in the build? Why CI shouldn’t be allowed to commit changes to the codebase? And are you suggesting to change pom.xml from “<goal>check</goal>” to “<goal>apply</goal>”? This will allow code that does not conform to the spotless format to be submitted. Li Yuheng > 2024年8月19日 22:46，Christofer Dutz <christofer.d...@c-ware.de> 写道： > > Running that on the master branch in the CI wouldn’t be helpful, as the CI > shouldn’t be allowed to commit changes to the codebase. > That’s why I’m suggesting calling the “apply” instead of the “check” goal in > our build. > > Chris > > Von: liyuheng <liyuheng55...@126.com> > Datum: Montag, 19. August 2024 um 15:02 > An: dev@iotdb.apache.org <dev@iotdb.apache.org> > Betreff: Re: [DISCUSS] How about running spotless:apply instead of > spotless:check in the build? > Hi, Chris > > Auto spotless is a great idea. For my opinion, we can do auto spotless in > master branch one time every day, and remove other spotless check. > > And +1 for spotless is still necessary.
