Hi Apache IoTDB community,

For PR #17810: https://github.com/apache/iotdb/pull/17810, I reviewed the
comments and plan to address them as follows:

   1.

   Add a grouped NEXT fill unit test for the same-group cross-TsBlock case,
   where a trailing null in one block should be filled by a later non-null
   value from the same group.
   2.

   Adjust grouped NEXT reset/lookahead logic so a prepared candidate from
   the same group survives resetFill, including the first segment of a
   group, while candidates from a later group are not prepared or are cleared
   before fill.
   3.

   Extend NextFillNodeSerdeTest to cover null serialization branches,
   including the plain FILL METHOD NEXT case where timeBound, helperColumn,
   and groupingKeys are all null.
   4.

   Add a defensive check/comment in TableNextFillOperator for the invariant
   that TIME_BOUND requires a resolved helper column.
   5.

   Optionally align PreviousFillNode#equals/hashCode with NextFillNode by
   including groupingKeys, for consistency.

After the changes, I will run the focused unit tests and spotless check for
the touched modules.

Best regards,
Bryan Yang (杨易达)

Reply via email to