[
https://issues.apache.org/jira/browse/ISIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708457#comment-13708457
]
Dan Haywood commented on ISIS-457:
----------------------------------
Hi Bilgin,
thanks for doing this, very decent effort!
I've applied the patch, all looks good, and pushed up to our repo.
I did notice just one place where the CSS class isn't rendered, namely for
actions that are placed alongside properties or collections. In the example
todo app, this would be the "done" and "undo" buttons by the "completed"
checkbox, and the "add" and "remove" buttons in the dependencies collection.
In terms of code, this is the AdditionalLinksPanel.
I've made some updates to the todo app, so if you'd be happy to finish off the
change, you could use that for test purposes. (todo app is in
examples/application/quickstart-w_r_j).
One last thing: I see you raised a separate ticket for some minor
formatting/spelling mistake fixes. I wouldn't have bothered myself with
raising a separate ticket ISIS-464 for that, would have done as part of this
ticket. Perhaps other ASF projects you've worked on are more pinnickity?
Thx again
Dan
> New annotation @CssClass for class member, should render in the HTML markup
> for that member.
> --------------------------------------------------------------------------------------------
>
> Key: ISIS-457
> URL: https://issues.apache.org/jira/browse/ISIS-457
> Project: Isis
> Issue Type: New Feature
> Components: Core, Viewer: Wicket
> Affects Versions: viewer-wicket-1.2.0, core-1.2.0
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: viewer-wicket-1.3.0, core-1.3.0
>
> Attachments: ISIS-457.patch
>
>
> for example:
> @CssClass("lock")
> public void lock() { ... }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
