[ 
https://issues.apache.org/jira/browse/ISIS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726193#comment-13726193
 ] 

ASF subversion and git services commented on ISIS-485:
------------------------------------------------------

Commit bdcfc4926fbac2080a837cd28d0049db9c36cc49 in branch refs/heads/master 
from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bdcfc49 ]

ISIS-485: fixes to integtest support tests

... were too brittle.

                
> Clearer messages for validation exceptions (specially MandatoryExceptions)
> --------------------------------------------------------------------------
>
>                 Key: ISIS-485
>                 URL: https://issues.apache.org/jira/browse/ISIS-485
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: core-1.2.0
>            Reporter: Oscar Bou
>            Assignee: Dan Haywood
>         Attachments: patch_validation_messages.diff
>
>
> Move from validation exception messages like this one:
> org.apache.isis.applib.services.wrapper.InvalidException: Mandatory
>       at 
> org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.toException(DomainObjectInvocationHandler.java:584)
>       at 
> org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.notifyListenersAndVetoIfRequired(DomainObjectInvocationHandler.java:556)
>       at 
> org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.handleActionMethod(DomainObjectInvocationHandler.java:506)
>       at 
> org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.invoke(DomainObjectInvocationHandler.java:236)
>       at 
> org.apache.isis.core.wrapper.internal.InvocationHandlerMethodInterceptor.intercept(InvocationHandlerMethodInterceptor.java:37)
>       at ....
> To clear messages like the following one that allow to better identify the 
> source of the validation exception:
> org.apache.isis.applib.services.wrapper.InvalidException: Source: 
> com.xms.framework.risk.domain.model.RiskRegister@2012052f. Reason: Mandatory. 
> Identifier: 
> com.xms.framework.risk.domain.model.RiskRegister#addQuantitativeRiskToAsset(java.lang.String,java.lang.String,com.xms.framework.architecture.domain.model.Entity,com.xms.framework.risk.domain.model.threat.Threat,java.math.BigDecimal,java.math.BigDecimal).
>  Position: 2. Proposed: null
>       at 
> org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.toException(DomainObjectInvocationHandler.java:584)
>       at 
> org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.notifyListenersAndVetoIfRequired(DomainObjectInvocationHandler.java:556)
>       at 
> org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.handleActionMethod(DomainObjectInvocationHandler.java:506)
>       at 
> org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.invoke(DomainObjectInvocationHandler.java:236)
>       at 
> org.apache.isis.core.wrapper.internal.InvocationHandlerMethodInterceptor.intercept(InvocationHandlerMethodInterceptor.java:37)
>       at ...
> }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to