Looks good to me too! Some comments: regexPatternReplacement: Is this the input placeholder? In that case I would choose to add a "placeholder" attribute on @PropertyLayout and @ParameterLayout [1]
regexPatternFlags: this is obsolete if you add "(?i)" to the pattern. Cheers, Jeroen [1] http://www.w3schools.com/tags/att_input_placeholder.asp On Mon, Dec 29, 2014 at 11:45 AM, Martin Grigorov <mgrigo...@apache.org> wrote: > Hi, > > Looks good to me! > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Mon, Dec 29, 2014 at 12:36 PM, Dan Haywood < > d...@haywood-associates.co.uk> > wrote: > > > Hi folks, > > > > have done some further tidy up on the new annotations for domain > semantics, > > ie @DomainObject, @Property, @Collection, @Action and @Parameter. > > > > Nothing yet implemented in terms of facet factories, but think I have the > > annotations themselves pretty much finalized [1]. > > > > Would appreciate a review from anyone interested, save me reworking stuff > > > > Cheers > > Dan > > > > [1] https://issues.apache.org/jira/browse/ISIS-970 > > >
