[ 
https://issues.apache.org/jira/browse/ISIS-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509055#comment-14509055
 ] 

ASF subversion and git services commented on ISIS-1085:
-------------------------------------------------------

Commit 1d82584114f75d786d78d5fbaff9e231cfbba2a5 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1d82584 ]

ISIS-1085: reviewing; reverting the deletion of ActionLayout.CssClassFaPosition 
and the introduction of CssClassFaPosition ...

... as this would break backward compatibility.  Instead introduced similar 
enums into DomainObjectLayout and ViewModelLayout.  The CssClassFaPosition enum 
itself moves from applib to core.metamodel.


> Add cssClassFa to DomainObjectLayout
> ------------------------------------
>
>                 Key: ISIS-1085
>                 URL: https://issues.apache.org/jira/browse/ISIS-1085
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Jörg Rade
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.9.0
>
>         Attachments: ScreenShot 090 SALOG 2.5.6.0 -_ 2.6.0.0-SNAPSHOT - 
> Mozilla Firefox.png, ScreenShot 091 IfcMgmt - Bndtools - 
> sdm-dom_src_main_java_sdm_dom_Application.java - Eclipse SDK.png
>
>
> * @CssClassFa is deprecated but is able to decorate DomainObjects with font 
> awesome icons.
> * this feature does not work reliably (in my app it works with 11 out 13 
> classes).
> * @DomainObjectLayout does not support cssClassFa currently
> # add attribute to @DomainObjectLayout, move/copy implementation
> # eventually fix bug
> # eventually remove deprecated annotation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to