[ 
https://issues.apache.org/jira/browse/ISIS-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643193#comment-14643193
 ] 

Oscar Bou edited comment on ISIS-1157 at 7/27/15 6:41 PM:
----------------------------------------------------------

Many thanks, Dan.

I've reviewed your changes. It has more sense. I wanted to impact existing 
implementations the less.
I think this feature is really useful for complex domains.

I've just made a dummy change request simply updating an error message.

Please review it and I'll mark this as closed.

Thanks again,

Oscar 


was (Author: oscarbou):
Many thanks, Dan.

I've reviewed your changesz. It has more sense. I wanted to impact existing 
implementations the less.
I think this feature is really useful for complex domains.

I've just made a dummy change request simply updating an error message.

Please review it and I'll mark this as closed.

Thanks again,

Oscar 

> Cache safe Actions results by annotating them
> ---------------------------------------------
>
>                 Key: ISIS-1157
>                 URL: https://issues.apache.org/jira/browse/ISIS-1157
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Oscar Bou
>            Assignee: Oscar Bou
>             Fix For: 1.9.0
>
>
> As discussed on the Isis mailing list [1].
> Currently, there's service called QueryResultsCache [2] that allows to cache 
> the results of an Action/method invocation.
> We want to introduce this capability for Safe Actions by simply annotating 
> them.
> Current proposal is to extend the "SemanticsOf" annotation param with a new 
> type: SemanticsOf.SAFE_AND_REQUEST_CACHED
> A usage example would be:
>  
> {code}
>     @Override
>     @Action(semantics = SemanticsOf.SAFE_AND_REQUEST_CACHED)
>     public SortedSet<IESG> relevantSnpGenotypes(final IE inputElement,
>             final Kit kit) {
>         if (kit != null) {
>             return 
> kit.findAllAssociatedSNPGenotypesForInputElement(inputElement, 
> AlgorithmImplementation.this.IESGClass);
>         } else {
>             return Sets.newTreeSet();
>         }
>     }
> {code}
> [1] 
> http://mail-archives.apache.org/mod_mbox/isis-users/201505.mbox/%3c575da9cb-14e6-4dd0-9565-c03c759bd...@gesconsultor.com%3E
> [2] https://isis.apache.org/reference/services/query-results-cache.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to