Hmm, this is what I'm not sure about. Just digging into the parent pom [1], it seems that the profile name is "apache-release", not "release"... I think I've convinced myself that putting toolchains under a profile of same name within our core/pom.xml should work. IIRC, profiles in each pom are combined/flattened, they aren't overridden.
Will try it out next release. thx Dan [1] https://repo1.maven.org/maven2/org/apache/apache/17/apache-17.pom On 12 January 2016 at 20:15, Martin Grigorov <mgrigo...@apache.org> wrote: > I am not familiar with "release" profile in Apache parent pom. > You can name it "isis-release" if you want. > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Tue, Jan 12, 2016 at 9:08 PM, Dan Haywood <d...@haywood-associates.co.uk > > > wrote: > > > Hi Martin, > > > > I considered that briefly, but I wasn't certain how to co-exist with the > > "release" Maven profile defined in the org.apache:apache parent pom. > Would > > it be as simple as also defining the "release" profile in our parent pom, > > and moving the toolchains plugin definition there? > > > > Thx > > Dan > > > > > > > > > > On 12 January 2016 at 19:49, Martin Grigorov <mgrigo...@apache.org> > wrote: > > > > > Hi Dan, > > > > > > To ease the Mac users you can move the m-toolchain-p into a profile > that > > is > > > used only for releasing. > > > If there is any problem you will notice it a bit later but IMO it is > not > > a > > > problem. You can setup the CI to always use the profile. > > > > > > Martin Grigorov > > > Wicket Training and Consulting > > > https://twitter.com/mtgrigorov > > > > > > On Tue, Jan 12, 2016 at 8:34 PM, Dan Haywood < > > d...@haywood-associates.co.uk > > > > > > > wrote: > > > > > > > Yes... at least from the mvn command line. It still can be built > fine > > > from > > > > within IntelliJ. > > > > > > > > Why do this? > > > > > > > > Previously we had <source>1.7</source> and <target>1.7</target> flags > > for > > > > the compiler plugin, but this didn't seem to prohibit the accidental > > use > > > of > > > > the JDK 1.8 APIs. > > > > > > > > So I think it's the only safe way to ensure backward compatibility > ... > > > and > > > > it is the way recommended by Maven. > > > > > > > > -- D > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 12 January 2016 at 19:31, Jeroen van der Wal <jer...@stromboli.it > > > > > > wrote: > > > > > > > > > I posted first ;-) > > > > > > > > > > Are you suggesting that building Isis from source would require > > > > installing > > > > > 1.7 JDK? > > > > > > > > > > On 12 January 2016 at 20:30, Dan Haywood < > > d...@haywood-associates.co.uk > > > > > > > > > wrote: > > > > > > > > > > > Hi Jeroen, > > > > > > > > > > > > Did you post your mail after my reply to Kevin? ... I described > the > > > > setup > > > > > > there. > > > > > > > > > > > > thx > > > > > > Dan > > > > > > > > > > > > > > > > > > On 12 January 2016 at 19:26, Jeroen van der Wal < > > jer...@stromboli.it > > > > > > > > > > wrote: > > > > > > > > > > > > > At my machine the toolchains plugin is complaining: > > > > > > > > > > > > > > [ERROR] Failed to execute goal > > > > > > > org.apache.maven.plugins:maven-toolchains-plugin:1.1:toolchain > > > > > (default) > > > > > > on > > > > > > > project isis: Cannot find matching toolchain definitions for > the > > > > > > following > > > > > > > toolchain types: > > > > > > > [ERROR] jdk [ vendor='oracle' version='1.7' ] > > > > > > > [ERROR] Please make sure you define the required toolchains in > > your > > > > > > > ~/.m2/toolchains.xml file. > > > > > > > [ERROR] -> [Help 1] > > > > > > > [ERROR] > > > > > > > [ERROR] To see the full stack trace of the errors, re-run Maven > > > with > > > > > the > > > > > > -e > > > > > > > switch. > > > > > > > [ERROR] Re-run Maven using the -X switch to enable full debug > > > > logging. > > > > > > > [ERROR] > > > > > > > [ERROR] For more information about the errors and possible > > > solutions, > > > > > > > please read the following articles: > > > > > > > [ERROR] [Help 1] > > > > > > > > > > > > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException > > > > > > > > > > > > > > I'll do some further research on this. > > > > > > > > > > > > > > > > > > > > > On 12 January 2016 at 19:46, Kevin Meyer <ke...@kmz.co.za> > > wrote: > > > > > > > > > > > > > > > Umm, is this just because I'm forcing compilation with jdk > 1.8? > > > (I > > > > > > don't > > > > > > > > have 1.7 installed): > > > > > > > > > > > > > > > > > > > > > > > > [ERROR] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > /home/kevin/isis/release/1.11.1/isis-1.11.1/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/value/vsp/ValueSemanticsProviderUtil.java:[48,72] > > > > > > > > error: incompatible types: bad type in conditional expression > > > > > > > > [ERROR] Class<CAP#1> cannot be converted to Class<? > extends > > > > > > > > ValueSemanticsProvider<?>> > > > > > > > > where CAP#1 is a fresh type-variable: > > > > > > > > CAP#1 extends Object from capture of ? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > /home/kevin/isis/release/1.11.1/isis-1.11.1/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/parseable/ParserUtil.java:[46,70] > > > > > > > > error: incompatible types: bad type in conditional expression > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sun, January 10, 2016 16:43, Dan Haywood wrote: > > > > > > > > > I've cut a release for Apache Isis Core and the simpleapp > > > > > archetype: > > > > > > > > > > > > > > > > > > > > > > > > > > > * Core 1.11.1 > > > > > > > > > * SimpleApp Archetype 1.11.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > This bug release fix is primarily because Isis 1.11.0 was > > > > released > > > > > > with > > > > > > > > > dependencies on JDK8. See ISIS-1296 for further details. > > > > > > > > > > > > > > > > > > The source code artefacts have been uploaded to staging > > > > > repositories > > > > > > on > > > > > > > > > repository.apache.org: > > > > > > > > > > > > > > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://repository.apache.org/content/repositories/orgapacheisis-1041/org/a > > > > > > > > > pache/isis/core/isis/1.11.1/isis-1.11.1-source-release.zip > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://repository.apache.org/content/repositories/orgapacheisis-1041/org/a > > > > > > > > > > > > > > > > > > > > > > > > > pache/isis/archetype/simpleapp-archetype/1.11.1/simpleapp-archetype-1.11. > > > > > > > > > 1-source-release.zip > > > > > > > > > > > > > > > > > > > > > > > > > > > For each zip there is a corresponding signature file > (append > > > .asc > > > > > to > > > > > > > the > > > > > > > > > zip's url). > > > > > > > > > > > > > > > > > > In the source code repo the code has been tagged as > > > > isis-1.11.1-RC1 > > > > > > and > > > > > > > > > simpleapp-archetype-1.11.1-RC1; see > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=isis.git > > > > > > > > > > > > > > > > > > > > > > > > > > > For instructions on how to verify the release (build from > > > > binaries > > > > > > > and/or > > > > > > > > > use in Maven directly), see > > > > > > > > > > > > > http://isis.apache.org/guides/cgcom.html#_cgcom_verifying-releases > > > > > > > > > > > > > > > > > > > > > > > > > > > Please verify the release and cast your vote. The vote > will > > be > > > > > open > > > > > > > for > > > > > > > > > a minimum of 72 hours. > > > > > > > > > > > > > > > > > > [ ] +1 > > > > > > > > > [ ] 0 > > > > > > > > > [ ] -1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Kevin Meyer > > > > > > > > Ljubljana, Slovenia > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
