[
https://issues.apache.org/jira/browse/ISIS-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255270#comment-15255270
]
ASF subversion and git services commented on ISIS-1390:
-------------------------------------------------------
Commit 98a0c2f8032f49178e9a048d4139e4d0af66c594 in isis's branch
refs/heads/ISIS-1291 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=98a0c2f ]
ISIS-1390: default CommandServiceDefault. Also simplifying the relationship
between IsisTransaction and Command, and how the Command object is initialized.
Also:
... deprecating CommandService#startTransaction(...), make it the
responsibility of IsisTransactionManager to populate the transactionId of the
Command in all cases.
... simplifying logic in IsisTransaction; the Command is only just created, so
will never have a transactionId to reuse. The design is now simply for the
IsisTransactionManager to create a new UUID and set on both the Command and
also pass into IsisTransaction.
... extend IsisTranscationManager's executeWithTransaction to allow an existing
Command to be passed in; leverage this from BackgroundCommandExecution.
Also:
... use ClockService to obtain the time, rather than Clock singleton (for
Command#setTimestamp, also Command#setStartedAt,
... make lookup of mandatory services fail-fast if not present
(PropertySetterFacet, ActionInvocationFacet, IsisTransactionManager,
IsisTransaction)
... minor alterations to visibility of DomainObjectJdoAbstract properties in
tables.
> Provide a default CommandService, to return CommandDefault.
> -----------------------------------------------------------
>
> Key: ISIS-1390
> URL: https://issues.apache.org/jira/browse/ISIS-1390
> Project: Isis
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.12.1
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Labels: implemented
> Fix For: 1.13.0
>
>
> This will simplify implementation wherever the CommandService is looked up.
> Currently we require null guards.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
