[
https://issues.apache.org/jira/browse/ISIS-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302347#comment-15302347
]
ASF subversion and git services commented on ISIS-1414:
-------------------------------------------------------
Commit 21b27fe49790adc78a3fe7804ff4feba7790bbed in isis's branch
refs/heads/ISIS-1414 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=21b27fe ]
ISIS-1414: moving the @RequestScoped initialization/close stuff out of
IsisTransactionManager and IsisTransaction, and into PersistenceSession.
Also:
- CommandService#startTransaction is no longer called.
- remove unused code/hashmap in PersistenceSession
> nextTransaction can cause null pointers with the new MetricsService.
> ---------------------------------------------------------------------
>
> Key: ISIS-1414
> URL: https://issues.apache.org/jira/browse/ISIS-1414
> Project: Isis
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.12.1
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 1.13.0
>
>
> The reason is that request-scoped services are implemented as transaction
> services. Most of the time the scope of a request and the scope of a
> transacion are one and the same: there is just one transaction per scope.
> However, TransactionService#nextTransaction admits for there being multiple
> transactions per request.
> This bug is that the current implementation for RequestScoped does the
> init/close as part of the Transaction management. Instead, this should be
> part of the PersistenceSession#open/close (a PersistenceSession wraps a JDO
> session, so basically corresponds to the request).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
