[
https://issues.apache.org/jira/browse/ISIS-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335768#comment-15335768
]
ASF subversion and git services commented on ISIS-1448:
-------------------------------------------------------
Commit 53626608c130bea75a471db3f94f750575a0d2f1 in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5362660 ]
ISIS-1448: reinstates the ability to switch component factory for entity
collection.
Prior to 1.12.0 the ComponentFactory SPI was used to lookup the component to
render an entity collection, using ComponentType.ENTITY_COLLECTION and passing
in an EntityModel with appropriate hints to indicate which collection of the
entity to render. The default implementation was EntityCollectionsPanelFactory
returning an EntityCollectionsPanel (the plural here is because there many
representations of a single collection, with a drop-down selector to choose
which).
In the 1.12.0 (layout XML stuff), this capability was lost: the new Col class
simply instantiates EntityCollectionPanel (renamed from EntityCollectionsPanel).
This commit reinstates the ability by having Col use the
ComponentFactoryRegistrar to look up the component to render the entity
collection.
The commit also deletes the CollectionPanelFactory; this code was unused.
CollectionPanel is the default table representation of the collection;
EntityCollectionPanel simply instantiates it and then keeps track of all the
"other" implementations to render the collection. To make this easier to
switch in, the code to instantiate a CollectionPanel within
EntityCollectionPanel has been moved to a (potentially overridable) factory
method.
> Reinstate component factory for collections, so that they can be easily
> substituted.
> ------------------------------------------------------------------------------------
>
> Key: ISIS-1448
> URL: https://issues.apache.org/jira/browse/ISIS-1448
> Project: Isis
> Issue Type: Improvement
> Components: Core: Viewer: Wicket
> Affects Versions: 1.12.0, 1.12.1, 1.12.2
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Fix For: 1.13.0
>
>
> The ability to easily swap out collections functionality was lost in 1.12.x
> (with the layout XML stuff). This is to reinstate it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
