[
https://issues.apache.org/jira/browse/ISIS-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927803#comment-15927803
]
ASF subversion and git services commented on ISIS-1595:
-------------------------------------------------------
Commit bfca3eeedeed3a4e7c597c50d4e1197b8be1e2ef in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bfca3ee ]
Merge branch 'ISIS-1595-jdoql-validation' of https://github.com/sanderginn/isis
into ISIS-1595_pr-70
> Configuration property for JDOQL VARIABLES clause mismatch
> ----------------------------------------------------------
>
> Key: ISIS-1595
> URL: https://issues.apache.org/jira/browse/ISIS-1595
> Project: Isis
> Issue Type: Bug
> Affects Versions: 1.14.0
> Reporter: Sander Ginn
>
> The [migration notes for
> 1.14.0|http://isis.apache.org/migration-notes.html#_migration-notes_1.13.0-to-1.14.0]
> states that the configuration property to check for JDOQL {{VARIABLES}}
> class name validity is:
> {{isis.reflector.validator.jdoqlVariablesClause}}
> However, the [corresponding facet
> factory|https://github.com/apache/isis/blob/master/core/metamodel/src/main/java/org/apache/isis/objectstore/jdo/metamodel/facets/object/query/JdoQueryAnnotationFacetFactory.java]
> defines the property differently:
> {{public static final String
> ISIS_REFLECTOR_VALIDATOR_JDOQL_VARIABLES_CLAUSE_KEY =
> "isis.reflector.validator.variablesFromClause";}}
> I would argue that the documentation's version is better, since the factory
> version is rather ambiguous with respect to the property that defines JDOQL
> {{FROM}} clause validation. I will raise a PR that changes the constant to
> match the documentation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
