[ 
https://issues.apache.org/jira/browse/ISIS-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106558#comment-16106558
 ] 

ASF subversion and git services commented on ISIS-1670:
-------------------------------------------------------

Commit 05a6624d797e4b4236e672500e0a5f45cca7f852 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=05a6624 ]

ISIS-1668: only enables prompt if the associated action is visible and enabled.

Note that this still leaves ISIS-1670 (view is not dynamic)... but since 
ISIS-1670 was a problem even for regular editable properties, decided that the 
fix in this commit addresses ISIS-1668 sufficiently.


> ScalarPanelAbstract2 in edit mode (or with INLINE_AS_IF_EDIT action) does not 
> dynamically update enablement/disability based on other state.
> --------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-1670
>                 URL: https://issues.apache.org/jira/browse/ISIS-1670
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.14.0
>            Reporter: Dan Haywood
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> ... because the gui is built during onInitialize callback, and this is called 
> when re-rendered
> Funnily enough, ScalarPanelAbstract (which ScalarPanelAbstract2 replaces) 
> uses onBeforeRender.
> Am guessing there was probably a reason to move the gui building to 
> onInitialize...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to