Great stuff Andy!
To maintain visibility to the community and keep the barrier for
collaboration low I would prefer that you keep working in master. But a
good feedback loop is important (I learned that from Dan) so we will
allocate some time to have a publicly available CI and Docker images of the
Helloworld and Kitchensink app.
When checking out master I run into compilation issues [1], does this also
happen on your side?
Cheers,
Jeroen
[1] mvn clean install -Dskip.app -Dskip.arch -DskipTests
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile
(default-testCompile) on project isis-core-plugins-jdo-datanucleus-4:
Compilation failure: Compilation failure:
[ERROR]
/Users/jvanderwal/src/github/apache/isis/core/plugins/jdo-datanucleus-4/src/test/java/org/apache/isis/core/wrapper/WrapperFactoryDefaultTest_wrappedObject_transient.java:[122,13]
cannot find symbol
[ERROR] symbol: class WrapperFactoryDefault
[ERROR] location: class
org.apache.isis.core.wrapper.WrapperFactoryDefaultTest_wrappedObject_transient
[ERROR]
/Users/jvanderwal/src/github/apache/isis/core/plugins/jdo-datanucleus-4/src/test/java/org/apache/isis/core/wrapper/WrapperFactoryDefaultTest_wrappedObject_transient.java:[215,15]
cannot find symbol
[ERROR] symbol: class WrapperFactoryDefault
[ERROR] location: class
org.apache.isis.core.wrapper.WrapperFactoryDefaultTest_wrappedObject_transient
[ERROR]
/Users/jvanderwal/src/github/apache/isis/core/plugins/jdo-datanucleus-4/src/test/java/org/apache/isis/core/wrapper/WrapperFactoryDefaultTest_wrappedObject.java:[140,13]
cannot find symbol
[ERROR] symbol: class WrapperFactoryDefault
[ERROR] location: class
org.apache.isis.core.wrapper.WrapperFactoryDefaultTest_wrappedObject
[ERROR]
/Users/jvanderwal/src/github/apache/isis/core/plugins/jdo-datanucleus-4/src/test/java/org/apache/isis/core/wrapper/WrapperFactoryDefaultTest_wrappedObject.java:[287,15]
cannot find symbol
[ERROR] symbol: class WrapperFactoryDefault
[ERROR] location: class
org.apache.isis.core.wrapper.WrapperFactoryDefaultTest_wrappedObject
--
Jeroen van der Wal
Stromboli b.v.
+31 655 874050
On 6 March 2018 at 10:28, Andi Huber <ahu...@apache.org> wrote:
> Thx Dan.
>
> I think, I can live with that no problem.
>
> However, M1 has grown structural rather far apart from the 'stable'
> branch, so any changes made on the 'stable' branch need to be merged
> into 'M1' not the other way around. Also the idea of rebasing M1 on
> 'stable' is no longer applicable. (At least that's what I think.)
>
> btw: I'm using the M1 build with my own projects now (on JEE 7 with
> axon, dn-5, shiro, patched excel and security modules from incode) and
> hence have high interest in fixing M1 related issues. ;)
>
> Cheers Andi
>
> On 06.03.2018 10:09, Dan Haywood wrote:
> > Hi Andi,
> >
> > Thanks for this, and the update.
> >
> > To expand on your status update, right now we have two main branches of
> > development:
> > - the "maint-1.16.2" branch ... this is where I cut the 1.16.2 release
> from
> > - the "master" branch, which holds the stuff intended for the 2.0.0-M1.
> >
> > Since "master" is currently unstable, I wonder if instead we should do a
> > force push and rename it for now, ie
> >
> > git checkout master
> > git checkout -b dev/2.0.0-M1
> > git push origin dev/2.0.0-M1 -u
> >
> > git reset --hard maint-1.16.2 # move local master to the current
> location
> > of maint-1.16.2
> > git push origin master -f # force push
> > git branch -D maint-1.16.2
> > git push origin maint-1.16.2 --delete
> >
> > Opinions?
> >
> > Thx
> > Dan
> >
> >
> >
> > On Tue, 6 Mar 2018 at 08:07 Andi Huber <ahu...@apache.org> wrote:
> >
> >> The 'master' branch intended for version (2.0.0-M1) is progressing:
> >>
> >> We've broken apart our core modules such that its now in the
> >> responsibility of developers to pick from the new core-plugins, what
> >> they want to include with their domain-code and web-app deployment.
> >>
> >> Meaning for migration, domain-code has new compile dependencies, which
> >> are provided from 4 categories of core-plugins:
> >> * Discovery (required)
> >> * JDO (required)
> >> * Eventbus (optional, required only if eventbus is needed, and for
> >> fixture-script to work properly)
> >> * JAX-RS (optional, required only if the restful viewer is needed)
> >>
> >> Giving an example of what you would need to add to your pom.xml file,
> >> when doing a conservative selection ...
> >>
> >> ---
> >>
> >> <dependency>
> >> <groupId>org.apache.isis.core</groupId>
> >> <artifactId>isis-core-plugins-discovery-reflections</artifactId>
> >> <version>${isis.version}</version>
> >> </dependency>
> >>
> >> <dependency>
> >> <groupId>org.apache.isis.core</groupId>
> >> <artifactId>isis-core-plugins-eventbus-guava</artifactId>
> >> <version>${isis.version}</version>
> >> </dependency>
> >>
> >> <dependency>
> >> <groupId>org.apache.isis.core</groupId>
> >> <artifactId>isis-core-plugins-jdo-datanucleus-4</artifactId>
> >> <version>${isis.version}</version>
> >> </dependency>
> >>
> >> <dependency>
> >> <groupId>org.apache.isis.core</groupId>
> >> <artifactId>isis-core-plugins-jaxrs-resteasy-3</artifactId>
> >> <version>${isis.version}</version>
> >> </dependency>
> >>
> >> ---
> >>
> >> We have variants to that:
> >> * eventbus-axon
> >> * datanucleus-5
> >> * resteasy-4 (for deployment to JEE 8)
> >>
> >> Breaking the core modules apart, might have introduced critical issues,
> >> so I'd like to encourage you, from time to time, to download the current
> >> 'master' from github, build from source and get involved with the
> >> process of shaping the first milestone release of version 2!
> >>
> >> There's still a lot of work to do:
> >> * Maven surfire tests fail, because we have missing dependencies with
> >> our pom.xml setup for testing.
> >> * Maybe some maven-expert could re-polish all core pom.xml files
> >> (structural-convention, comments, maybe simplify, ...).
> >> * More JUnit Tests needed to test mission-critical
> >> org.apache.isis.applib.internal.* classes.
> >> * More JUnit Tests needed to test mission-critical
> >> org.apache.isis.applib.util.ObjectContracts|ToString|Equality|Hashing.
> >> * Also someone could write a docker file that downloads the current
> >> 'master' source from github, starts the maven build and launches a
> >> tomcat with the helloworld app. (Can later be extended for different
> >> core-plugin combinations or other containers like JEE7 and JEE8)
> >>
> >> Anyways, happy coding out there!
> >>
> >> Cheers, Andi
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
>
>
>
