[
https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696507#comment-16696507
]
ASF subversion and git services commented on ISIS-2043:
-------------------------------------------------------
Commit c568147d62ed6f5519e61051cdc26c6ce4ff83ad in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c568147 ]
ISIS-2043: adds support for @DomainObject(xxxDomainEvent=...) for mixins
whereby will honour the domain event specified if not otherwise annotated.
In fact, this contains a few other fixes:
* previously, although mixin actions did emit domain events for all phases
(hide/disable/validate/executing/executed), mixin properties and mixin
collections emitted none. Now this is fixed so that the emit domain events for
the first two phases (hide/disable). It doesn't make sense to emit them for
the remainder because mixin props/colls are always derived (are read-only
queries under the covers).
* also, getMixedIn() now promoted from ActionDomainEvent up to
AbstractDomainEvent
* also, added similar getSubject() (a simple wrapper around getSource() and
getMixedIn()) also in AbstractDomainEvent.
> Allow domain events to be specified at @DomainObject, and make mixins aware
> of this.
> ------------------------------------------------------------------------------------
>
> Key: ISIS-2043
> URL: https://issues.apache.org/jira/browse/ISIS-2043
> Project: Isis
> Issue Type: New Feature
> Affects Versions: 1.16.2
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Major
> Fix For: 1.16.3
>
>
> Thus:
> {code:java}
> @DomainObject(
> ...,
> actionDomainEvent=IncomingInvoice.ActionDomainEvent.class,
> propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
> collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
> )
> public class IncomingInvoice {
> public static class ActionDomainEvent
> extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
> // etc
> }{code}
> then, for this domain event would be used as the default for any actions etc.
> Two refinements to this:
> a) for mixins, the event type emitted by a mixin action should be that of its
> mixee if possible. This does mean that the domain event must use <Object> as
> its generic type, because the source could either be the regular domain
> object or a mixin. This seems reasonable, the subscriber can just call
> ev.getMixee() to determine the original source.
> b) as a metamodel validation, if there are members that already define their
> own event types, then these event types should inherit from the types defined
> in @DomainObject. However, not sure exactly how well this plays with
> requirement from (a) that the generic type is <Object>.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
