[ https://issues.apache.org/jira/browse/ISIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026826#comment-17026826 ]
ASF subversion and git services commented on ISIS-2192: ------------------------------------------------------- Commit ef123c3187538904c50c4a7d41d9d8421660d6b8 in isis's branch refs/heads/master from danhaywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=ef123c3 ] ISIS-2192: sorting out dependencies go the other way. Also add in fakedata for all 3 > Improve the mavendeps-testing, to avoid accidental junit 4 dependency > --------------------------------------------------------------------- > > Key: ISIS-2192 > URL: https://issues.apache.org/jira/browse/ISIS-2192 > Project: Isis > Issue Type: Improvement > Reporter: Daniel Keir Haywood > Assignee: Daniel Keir Haywood > Priority: Major > Fix For: 2.0.0 > > > At the moment the isis-mavendeps-testing defines transitive dependencies on > both unittestsupport and integtestsupport. > > unittestsupport defines the JMock rule stuff, which depends on junit 4: don't > want to change this for now. > > for integtestsupport, though, want to force upgrade to junit 5, which also > means removing any accidental dependencies on junit:junit:4.x > > The following dependency for integ tests works, but think it might be better > to define two different mavendeps, one for unit testing and one for integ > testing. > > <dependency> > <groupId>org.apache.isis.mavendeps</groupId> > <artifactId>isis-mavendeps-testing</artifactId> > <type>pom</type> > <scope>test</scope> > <exclusions> > <exclusion> > <groupId>org.apache.isis.core</groupId> > <artifactId>isis-unittestsupport</artifactId> > </exclusion> > <exclusion> > <groupId>org.junit.vintage</groupId> > <artifactId>junit-vintage-engine</artifactId> > </exclusion> > </exclusions> > </dependency> -- This message was sent by Atlassian Jira (v8.3.4#803005)