[ 
https://issues.apache.org/jira/browse/ISIS-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2759:
--------------------------------------
    Description: 
was resulting in mixin not rendering, even though was in metamodel

for example:
{code:java}
 @RequiredArgsConstructor
public abstract class UpdateTimeWindow {
  private final BaseEntity baseEntity;

  public abstract TimeWindow getTimeWindow();  // <<<<<<<<<<< PROBLEMATIC...
  public abstract void initTimeWindow();       // <<<<<<<<<<<

  public BaseEntity act(String startTime, String endTime) {
    if (getTimeWindow() == null) {
      initTimeWindow();
    }
    getTimeWindow().setValue(startTime, endTime);
    return baseEntity;
  }
{code}
and then:
{code:java}
public class UpdateAdvanceDeliveryTimeWindow extends UpdateTimeWindow {
    public UpdateAdvanceDeliveryTimeWindow() {
        super(Client.this);
    }
    public BaseEntity act(String startTime, String endTime) { return 
super.act(startTime, endTime); }
    public TimeWindow getTimeWindow() {
        return Client.this.getAdvanceDeliveryTimeWindow();
    }
    public void initTimeWindow() {
        advanceDeliveryTimeWindow = new TimeWindow();
    }
}
 {code}
where `TimeWindow` is an embedded entity.

UPDATE:

Even making these supporting methods protected didn't seem to do the job...

 

  was:
was resulting in mixin not rendering, even though was in metamodel

for example:
{code:java}
 @RequiredArgsConstructor
public abstract class UpdateTimeWindow {
  private final BaseEntity baseEntity;

  public abstract TimeWindow getTimeWindow();  // <<<<<<<<<<< PROBLEMATIC...
  public abstract void initTimeWindow();       // <<<<<<<<<<<

  public BaseEntity act(String startTime, String endTime) {
    if (getTimeWindow() == null) {
      initTimeWindow();
    }
    getTimeWindow().setValue(startTime, endTime);
    return baseEntity;
  }
{code}
and then:
{code:java}
public class UpdateAdvanceDeliveryTimeWindow extends UpdateTimeWindow {
    public UpdateAdvanceDeliveryTimeWindow() {
        super(Client.this);
    }
    public BaseEntity act(String startTime, String endTime) { return 
super.act(startTime, endTime); }
    public TimeWindow getTimeWindow() {
        return Client.this.getAdvanceDeliveryTimeWindow();
    }
    public void initTimeWindow() {
        advanceDeliveryTimeWindow = new TimeWindow();
    }
}
 {code}
where TimeWindow is an embedded entity


> Either validate or ignore public helper methods in mixin superclass ... (was 
> resulting in mixin not rendering, even though was in metamodel)
> --------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-2759
>                 URL: https://issues.apache.org/jira/browse/ISIS-2759
>             Project: Isis
>          Issue Type: Improvement
>            Reporter: Daniel Keir Haywood
>            Priority: Major
>             Fix For: 2.0.0-M6
>
>
> was resulting in mixin not rendering, even though was in metamodel
> for example:
> {code:java}
>  @RequiredArgsConstructor
> public abstract class UpdateTimeWindow {
>   private final BaseEntity baseEntity;
>   public abstract TimeWindow getTimeWindow();  // <<<<<<<<<<< PROBLEMATIC...
>   public abstract void initTimeWindow();       // <<<<<<<<<<<
>   public BaseEntity act(String startTime, String endTime) {
>     if (getTimeWindow() == null) {
>       initTimeWindow();
>     }
>     getTimeWindow().setValue(startTime, endTime);
>     return baseEntity;
>   }
> {code}
> and then:
> {code:java}
> public class UpdateAdvanceDeliveryTimeWindow extends UpdateTimeWindow {
>     public UpdateAdvanceDeliveryTimeWindow() {
>         super(Client.this);
>     }
>     public BaseEntity act(String startTime, String endTime) { return 
> super.act(startTime, endTime); }
>     public TimeWindow getTimeWindow() {
>         return Client.this.getAdvanceDeliveryTimeWindow();
>     }
>     public void initTimeWindow() {
>         advanceDeliveryTimeWindow = new TimeWindow();
>     }
> }
>  {code}
> where `TimeWindow` is an embedded entity.
> UPDATE:
> Even making these supporting methods protected didn't seem to do the job...
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to