[
https://issues.apache.org/jira/browse/ISIS-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526426#comment-17526426
]
ASF subversion and git services commented on ISIS-3017:
-------------------------------------------------------
Commit 4d81d58ec04b42155153ea4996efc7a2ee67be3a in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=4d81d58ec0 ]
ISIS-3017: adds warning toast on recognized ex. in
WebRequestCycleForIsis
> [Wicket Viewer] WebRequestCycleForIsis does not display recognizable error.
> ---------------------------------------------------------------------------
>
> Key: ISIS-3017
> URL: https://issues.apache.org/jira/browse/ISIS-3017
> Project: Isis
> Issue Type: Improvement
> Components: Wicket Viewer
> Affects Versions: 2.0.0-M7
> Reporter: Miklós Győrfi
> Assignee: Andi Huber
> Priority: Major
> Fix For: 2.0.0-RC1
>
>
> In WebRequestCycleForIsis onException there is a code:
> {code:java}
> val exceptionRecognizerService = getExceptionRecognizerService();
> val recognizedIfAny = exceptionRecognizerService.recognize(ex);
> if(recognizedIfAny.isPresent()) {
> return respondGracefully(cycle);
> } {code}
> So it recognizes the error, but does not display it.
>
> Maybe
>
> {code:java}
> val exceptionRecognizerService = getExceptionRecognizerService();
> val recognizedIfAny = exceptionRecognizerService.recognize(ex);
> if(recognizedIfAny.isPresent()) {
> getMessageBroker().ifPresent(broker->{
> String msg =
> recognizedIfAny.get().toMessage(getCommonContext().getTranslationService());
> if (msg != null) {
> broker.addMessage(
> msg);
> }
> });
> return respondGracefully(cycle);
> }
> {code}
> could work well.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
