[ 
https://issues.apache.org/jira/browse/JCR-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498576
 ] 

Jukka Zitting commented on JCR-927:
-----------------------------------

Thanks, Dominique!

> With respect to the JNDI datasource feature, I'd like to include this feature 
> directly inside the
> DatabaseJournal class, where the user may either specify url/driver or 
> datasource as arguments.
> I prefer this to the separate class construct. 

Fair enough. I'm mostly worried about duplicating code, not about how and where 
the configuration and control lies. Perhaps we can see some consolidation later 
on.


> DatabaseJournal needs connection reestablishment logic
> ------------------------------------------------------
>
>                 Key: JCR-927
>                 URL: https://issues.apache.org/jira/browse/JCR-927
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3
>            Reporter: Hemanta Gupta
>         Assigned To: Dominique Pfister
>            Priority: Minor
>         Attachments: JNDIDatabaseJournal.java
>
>
> The DB based file system and persistence manager implementations have logic 
> for connection reestablishment in case the DB server bounces while the 
> repository is running, but the DB based journal implementation doesn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to