[ 
https://issues.apache.org/jira/browse/JCR-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger resolved JCR-967.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4

> I didn't provide a default implementation of needsSystemTree() on purpose 
> because I wanted
> to force everyone extending QueryNode to think about if his implementation 
> needs the system
> tree or not.

Ok, fair enough.

Based on your ASF license grant on the patch I added a license header to 
PathQueryNodeTest, which was missing. I also added JavaDoc to the new method 
SearchIndex.getIndexReader(boolean) and opened up the visibility to protected.

Thanks a lot for your work!

Committed the patch in revision: 550419

> Only search the index for the "jcr:system" tree if needed
> ---------------------------------------------------------
>
>                 Key: JCR-967
>                 URL: https://issues.apache.org/jira/browse/JCR-967
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: query
>    Affects Versions: 1.3
>            Reporter: Christoph Kiehl
>             Fix For: 1.4
>
>         Attachments: patch.txt
>
>
> Right now every time a query is executed the index of the current workspace 
> as well as the index of the "jcr:system" tree is searched. A lot of queries 
> are not searching in the "jcr:system" tree at all therefore it should be 
> checked if the query contains paths that include "jcr:system". There are two 
> relevant nodes in the query tree to find that out:
> - what's the first location step and does it include the jcr:system tree? I 
> think that's an easy one.
> - does the query contain a jcr:deref node? If there is an intermediate result 
> of a query may dereference into the jcr:system tree. 
> This should notably speed up query execution if you are working extensively 
> with versioning.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to