[ 
https://issues.apache.org/jira/browse/JCR-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509104
 ] 

Marcel Reutegger commented on JCR-989:
--------------------------------------

Thank you for the patch.

Wouldn't it be more intuitive to set the resultFetchSize on the Query instance 
instead of the QueryResult? With your current patch one will call:

QueryManager qm = ...
Query q = qm.createQuery(myQuery, Query.XPath);
QueryResult result = q.execute();
((LazyQueryResultImpl) result).setResultFetchSize(10);
NodeIterator nodes = result.getNodes();
...

I think the following is more intuitive:

QueryManager qm = ...
Query q = qm.createQuery(myQuery, Query.XPath);
((QueryImpl) query).setResultFetchSize(10);
QueryResult result = q.execute();
NodeIterator nodes = result.getNodes();
...

> Modify LazyQueryResultImpl to allow resultFetchSize to be set programmatically
> ------------------------------------------------------------------------------
>
>                 Key: JCR-989
>                 URL: https://issues.apache.org/jira/browse/JCR-989
>             Project: Jackrabbit
>          Issue Type: New Feature
>          Components: query
>    Affects Versions: 1.3
>            Reporter: Christoph Kiehl
>            Priority: Minor
>         Attachments: LazyQueryResultImpl.patch
>
>
> In our application we have a search which only shows part of a query result. 
> We always know which part of the result needs to be shown. This means we know 
> in advance how many results need to be fetched. I would like to be able to 
> programmatically set resultFetchSize to minimize the number of loaded lucene 
> docs and therefore improve the performance.
> I know it is already possible to the set the resultFetchSize via the index 
> configuration, but this number is fixed and doesn't work well in environments 
> where you use paging for your results because if you set this number too low 
> the query will be executed multiple times and if you set it too high too many 
> lucene docs are loaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to