[ 
https://issues.apache.org/jira/browse/JCR-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536698
 ] 

Jukka Zitting commented on JCR-1181:
------------------------------------

Angela:
> however, if you would like to make jackrabbit-core and jcr2spi use them, i 
> would suggest to move them
> out of the jcr-commons project as well and adjust them in order to get rid of 
> their usage of QName and
> the other deprecated classes.

The classes in org.apache.jackrabbit.commons use the (now deprecated) QName 
class for a few namespace constants. In fact I just dropped the dependency by 
copying the jcr and mix URI string constants to o.a.j.commons.AbstractNode in 
revision 587120.

The classes are intimately related to the JCR API boundary and they only deal 
with prefixed names in string format. There are no dependencies to SPI 
concepts. Thus I'd rather keep the classes in jcr-commons instead of 
spi-commons. Alternatively we could (or perhaps should!) move them over to 
jcr2spi, but I'm not sure if we're yet ready to introduce jcr2spi as a 
dependency to jackrabbit-core.

> Use common base classes in jackrabbit-core and jcr2spi
> ------------------------------------------------------
>
>                 Key: JCR-1181
>                 URL: https://issues.apache.org/jira/browse/JCR-1181
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, SPI
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>         Attachments: JCR-1181.patch
>
>
> As part of JCR-742 I've implemented a number of generic JCR base classes and 
> adapters in org.apache.jackrabbit.commons. These classes are based on 
> existing code in jackrabbit-core.
> To encourage code reuse across jackrabbit-core and jcr2spi, I'd like to make 
> both components use these generic base classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to