[ 
https://issues.apache.org/jira/browse/JCR-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543554
 ] 

Ard Schrijvers commented on JCR-1214:
-------------------------------------

:-) thanks again (by the way after filing the jira issue ofcourse I did not 
intend to not solve the issue. I thought trying JCR-1213 in combination with 
this one to not create an extra patch because this one is such a basic one) 
Anyway, thanks for solving it, and I'll try to get the patch with respect to 
1213 somewhere this week/weekend. 

> DocId.UUIDDocId should not have a string attr uuid
> --------------------------------------------------
>
>                 Key: JCR-1214
>                 URL: https://issues.apache.org/jira/browse/JCR-1214
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: query
>    Affects Versions: 1.3.3
>            Reporter: Ard Schrijvers
>            Assignee: Marcel Reutegger
>             Fix For: 1.4
>
>
> After JCR-1213 will be solved, lots of DocId.UUIDDocId can be cached, and not 
> being cleaned after every gc(). The number of cached UUIDDocId can grow very 
> large, depending on the size of the repository.  Therefor, instead of storing 
> the private String uuid; we can make it more memory efficient by storing 2 
> long's, the lsb and msb of the uuid.  Storing 1.000.000 of parent UUIDDocId 
> might differ about 100Mb of memory. 
> I even did test by removing the entire uuid string, and not use msb or lsb, 
> because, when everything works properly (with references to index reader 
> segments (See JCR-1213)), the uuid is never needed again: in 
> UUIDDocId getDocumentNumber(IndexReader reader) throws IOException {
> we could set uuid = null just before the return. It works perfectly well, 
> because when an index reader is recreated, the CachingIndexReader will be 
> recreated, hence DocId[] parents will be recreated. 
> So, IMO, I think we might be able to remove the uuid entirely when the 
> docNumber is found in DocId.UUIDDocId (obviously after JCR-1213)
> WDOT?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to