Hi Thomas.
I've been reviewing the new DbDataStore and have a few comments about it.

* doesn't synchronizing the addRecord() method, and using only one connection 
defeat one of the 
purposes of the data store of allowing maximum concurrency?

* making the SQL strings private and not initializing them in a method of its 
own really complicates 
extending the implementation (in any case, the SQL strings should be written as 
"UPDATE " + tableSQL 
+ "DATASTORE SET DATA=? WHERE ID=?")

* during a Session.save() there are various calls to DbDataStore.getRecord() 
and 
DbDataRecord.getStream(), for storing the blob int the blobStore. Why is this 
necesary if the binary 
content is already in the data store? It seems that this copy is overwritten 
every time, but I don't 
see the reason for all this calls to the DB, and file copies.

I'll be looking at this some more next week.

Regards,

Esteban Franqueiro
[EMAIL PROTECTED] 


Notice:  This email message, together with any attachments, may contain 
information  of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated 
entities,  that may be confidential,  proprietary,  copyrighted  and/or legally 
privileged, and is intended solely for the use of the individual or entity 
named in this message. If you are not the intended recipient, and have received 
this message in error, please immediately return this by email and then delete 
it.

Reply via email to