[ 
https://issues.apache.org/jira/browse/JCR-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575017#action_12575017
 ] 

Jukka Zitting commented on JCR-1452:
------------------------------------

Agreed about the general point to have such test and make them parametrized.

My point is that it should be the test writer who defines what are the 
reasonable parameter values. You could for example decide that we should run 
the 85%/1s tests per each build and the 95%/1m tests daily in a CI build. And 
if you want a super test case for 99%/1d, then you just add another instance 
with new parameters. In all these cases the writer of the test case is in the 
best position to decide what are the reasonable parameters for each test run.

If we just have a generic scale parameter, should in this case be set to the 
target error detection rate, the amount of time the test should run, the scale 
of time (1=1s, 2=2m, 3=1h, 4=1d) the test should run, or something else? And 
this is just a single test case, what about multiple different types of tests? 
Do the different types of tests even scale similarly?

IMHO the only reasonable way to use the scale parameter would be to define a 
set of accepted values, like 1=mvn package, 2=mvn install, 3=daily CI build, 
4=weekly CI build, but then it would be much more cleaner to just handle that 
using something like a Maven build profile.


> Make use of jackrabbit.test.scale in test cases
> -----------------------------------------------
>
>                 Key: JCR-1452
>                 URL: https://issues.apache.org/jira/browse/JCR-1452
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>             Fix For: 1.5
>
>
> There are already a number of longer running test cases in jackrabbit-core, 
> but they are all disabled because they otherwise make building 
> jackrabbit-core a very long task.
> Those tests should make use of the jackrabbit.test.scale property and per 
> default (scale = 1) run within a short time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to