[ 
https://issues.apache.org/jira/browse/JCR-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577875#action_12577875
 ] 

Felix Meschberger commented on JCR-1233:
----------------------------------------

Just my €.02 from the perspective of an OSGi user and modularization lover: 
Having all these classes mixed with internal implementation code prevents 
proper separation of API and implementation and in fact prevents proper OSGi 
separation. For example, it would be almost impossible to make the API 
externally visible and not at the same time make the implementation visible ...

IMHO this is not a matter of  making "jackrabbit look better in code quality 
tools", it is a matter of good programming style (oh yeah, another one from 
pandorra's box) supporting separation of concern.

> Create org.apache.jackrabbit.core.id
> ------------------------------------
>
>                 Key: JCR-1233
>                 URL: https://issues.apache.org/jira/browse/JCR-1233
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Jukka Zitting
>            Priority: Minor
>
> I'd like to create a separate package for the identifier interfaces and 
> classes in jackrabbit-core. Currently all the identifiers are in 
> org.apache.jackrabbit.core, which makes almost all the other packages have 
> dependencies to o.a.j.core and causes trouble for various package-level code 
> quality and dependency analysis tools.
> For now the package would contain the ItemId, NodeId, and PropertyId classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to