[
https://issues.apache.org/jira/browse/JCR-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584041#action_12584041
]
Julian Reschke commented on JCR-1508:
-------------------------------------
>you want a SPI call to check if the property exists and if it's value can be
>changed to a new value?
>i'm not in favour of this. unless the property is a huge binary, i would argue
>that reading the propertyInfo is not more expensive that having an SPI call to
>check the existance and the validity of the new Value.
No, that was not the proposal.
I would propose that JCR2SPI just calls SPI to *set* the value, and the
responsibility for checking lies inside the SPI implementation.
In general, JCR2SPI should not do things that can be done more efficiently
inside the SPI implementation.
> Setting a new property value causes a read of the previous property value
> -------------------------------------------------------------------------
>
> Key: JCR-1508
> URL: https://issues.apache.org/jira/browse/JCR-1508
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr2spi
> Affects Versions: 1.4
> Reporter: David Rauschenbach
>
> When using JCR2SPI with a custom SPI, getProperty is called when one attempts
> to set a new property value with disregard to the previous value. The current
> JCR2SPI implementation causes a getPropertyInfo, which requests the old value
> from the back-end. This is fundamentally unsound, and kills performance.
> An SPI has no choice but to guard against this by returning a PropertyInfo
> proxy that performs lazy-loading of the value. The problem is that if an
> error occurs when dereferencing the value, and when performing the lazy-load,
> JCR2SPI is ill-suited to hande an unchecked exception at such a time.
> Besides, it is a "hack upon a hack", because JCR2SPI could do this work
> itself, by making proper use of the SPI functions for requesting property
> type information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
