[
https://issues.apache.org/jira/browse/JCR-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boni Gopalan updated JCR-1758:
------------------------------
Attachment: UndefinedTypeConverterImpl.java
Patch for the Issue reported.
Modified getValue() method to use instanceof at the place of Class.equals()
Ran and passed all the tests in jackrabbit-ocm.
> Improvement to UndefinedTypeConverterImpl to map super types effectively
> ------------------------------------------------------------------------
>
> Key: JCR-1758
> URL: https://issues.apache.org/jira/browse/JCR-1758
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-ocm
> Environment: Any Java Version.
> Reporter: Boni Gopalan
> Priority: Minor
> Fix For: 1.5
>
> Attachments: UndefinedTypeConverterImpl.java
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Improvement to
> org.apache.jackrabbit.ocm.manager.atomictypeconverter.impl.UndefinedTypeConverterImpl's
> implementation of
> public Value getValue(ValueFactory valueFactory, Object propValue) , used
> equality check of class names to decide whether Object propValue is worthy of
> any attempt to map to an apropriate property. Since the purpose of the class
> is to provide a 'best effort' attempt to map an Object of type
> java.lang.Object it will be better to use 'instanceof'. This approach will
> convert the specific class as well as any inherited objects. For example
> using instanceof will let us map a BufferedInputStream, and any other sub
> classes of InputStream to a Binary Property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
