[ 
https://issues.apache.org/jira/browse/JCR-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643157#action_12643157
 ] 

Thomas Mueller commented on JCR-1822:
-------------------------------------

Hi,

Thanks for the patch, but could you change the title please? Usually the title 
of an issue says what the change is about. If the patch is for two different 
things, it makes sense to split the patch. Example:

"MS SQL Server tablespace support"

"DatabaseJournal test case for Oracle"

Regards,
Thomas 

> Patches for previously incompleted patches
> ------------------------------------------
>
>                 Key: JCR-1822
>                 URL: https://issues.apache.org/jira/browse/JCR-1822
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: core 1.4.6
>            Reporter: Brian Whipple
>         Attachments: jackrabbit-core.diff
>
>
> This is a patch to complete two earlier patches that were partially patched.
> JCR-1295 contained patch code for MS SqlServer tablespace support for the 
> filesystem and db persistence manager that was not applied.  I have cleaned 
> up the submitted code and it should be applied to be consistent.
> JCR-1362 was a fix for Oracle schema test that was applied to 1.4 branch from 
> trunk but was incomplete.
> This is a single patch for both issues.
> The fix for JCR-1362 only requires updating a single file from the patch: 
> src/main/java/org/apache/jackrabbit/core/journal/DatabaseJournal.java
> All other files are related to completing JCR-1295.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to