[ 
https://issues.apache.org/jira/browse/JCR-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649062#action_12649062
 ] 

Thomas Mueller commented on JCR-1865:
-------------------------------------

* MarkEventListener.started(): agreed. I'm not sure if this would be fully 
backward compatible: existing ScanEventListeners don't implement this method. 
When calling this method on an old implementation, the JVM would throw a 
java.lang.AbstractMethodError. This could be caught and ignored.

* getPersistenceManagerScan() method to isPersistenceManagerScan(): agreed.

* millis parameter to the setSleepBetweenNodes as long: agreed. 
getSleepBetweenNodes(): agreed.

* stopScan(): you are right, it doesn't belong to the interface. It is used for 
testing only.

* mark() and sweep(): agreed. We could still call it getPersistenceManagerScan 
however

* single method "gc()": multiple repositories can use the same data store 
(sharing the data store). In that case, you need to call mark() of all 
repositories before calling sweep() (on the first repository).

> Add the Data Store to the Jackrabbit API
> ----------------------------------------
>
>                 Key: JCR-1865
>                 URL: https://issues.apache.org/jira/browse/JCR-1865
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>            Priority: Minor
>         Attachments: api.patch, core.patch
>
>
> Currently, the garbage collection is not part of the Jackrabbit API. However, 
> the data store garbage collection must be used once in a while if the data 
> store is enabled. I propose to add the required interfaces to the Jackrabbit 
> API. This will also allow to call garbage collection using RMI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to