[ https://issues.apache.org/jira/browse/JCRRMI-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663324#action_12663324 ]
Felix Meschberger commented on JCRRMI-3: ---------------------------------------- +1 with remark: The exception thrown is a RuntimeException, which would be nice to have documented in JavaDoc, but which should declared in a throws clause on the signature. > Session.isLive() and logout() throw exceptions > ---------------------------------------------- > > Key: JCRRMI-3 > URL: https://issues.apache.org/jira/browse/JCRRMI-3 > Project: Jackrabbit JCR-RMI > Issue Type: Bug > Reporter: Marcel Reutegger > Priority: Minor > > The two methods will throw an exception in case the remote session is not > available anymore. For most other methods an exception is OK in that case, > but I think for the methods isLive() and logout() (both do not declare any > exception) a client expects a different behavior. I propose we change it as > follows: > - Session.isLive(): return false if remote session is not available anymore > - Session.logout(): write a log message, but do not throw a runtime exception. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.