[
https://issues.apache.org/jira/browse/JCR-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Mueller resolved JCR-2128.
---------------------------------
Resolution: Fixed
Assignee: Thomas Mueller
Committed in revision 783383 (trunk).
Test case fixed in revision 783386 (trunk).
Thanks a lot for the patch! A few remarks:
1) Originally I wanted to use the same class (DbDataStore) for all databases to
simplify configuration (and maybe implementation). But in this case it makes
sense to use a different class.
2) super.close(); is called twice in your patch. I added a remark: "need to
call it again because we just opened a connection, and super.close() closes it."
> Adding DerbyDataStore to handle proper close of the embedded database
> ---------------------------------------------------------------------
>
> Key: JCR-2128
> URL: https://issues.apache.org/jira/browse/JCR-2128
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Reporter: Cédric Damioli
> Assignee: Thomas Mueller
> Fix For: 1.6.0
>
> Attachments: DerbyDbDataStore.patch
>
>
> When using embedded Derby in conjunction with DbDataStore, the Derby database
> is never shutdown, as it requires special code to be executed (creating a
> Connection with ";shutdown=true")
> We may provide a DerbyDataStore extending standard DbDataStore for handling
> that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
