[ 
https://issues.apache.org/jira/browse/JCR-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718495#action_12718495
 ] 

angela commented on JCR-2144:
-----------------------------

Obvious simplifications would include:

- InternalValue.getLength instead of InternValue.getBLOBFileValue().getLength()
- InternalValue.discard() instead of InternalValue.getBLOBFileValue().discard()

Furthermore i got the impression that in most cases instances of InternalValue 
could be reduced to the interface.

The most frequent reason why the functionality exposed by the interface isn't 
sufficient is InternalValue.getUUID() used to build a new NodeId (reference 
tracking, accessing nodes by uuid etc...). 
This is related to the discussion in JCR-1232.




> InternalValue refactoring
> -------------------------
>
>                 Key: JCR-2144
>                 URL: https://issues.apache.org/jira/browse/JCR-2144
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>            Reporter: Thomas Mueller
>
> Now that we have use the value factory from spi-commons, the InternalValue 
> code should be simplified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to