[ https://issues.apache.org/jira/browse/JCR-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jared Roberts updated JCR-1525: ------------------------------- Attachment: JCR-1525.patch I took the liberty of updating the patch with a couple of modifications. The first is to rename the classes to align with the conventions that Thomas mentioned. Instead of Oracle9FileSystem, I chose Oracle10R1FileSystem, though. It seemed to make more sense, because that's technically the last version it supports. The second change I made was to remove the user/password initialization in the OracleBaseFileSystem constructor. Initializing them to empty strings causes problems when a JNDI data source is being used. They should be left null unless explicitly configured. > Jackrabbit depends on Oracle driver for BLOB support in Oracle versions > previous than 10.2 > ------------------------------------------------------------------------------------------ > > Key: JCR-1525 > URL: https://issues.apache.org/jira/browse/JCR-1525 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-core > Reporter: Esteban Franqueiro > Attachments: JCR-1525.patch, JCR-1525.patch > > > In Oracle versions previous to 10.2, Jackrabbit explicitly uses a class from > the Oracle driver to provide BLOB support (see OracleFileSystem.init()). This > special handling is no longer necesary for Oracle 10.2+, so we should provide > a new implementation. As discussed on the list, we can create a new class for > Oracle 10.2+, make it inherit from DbFileSystem, and override the > createSchema(), and table space related methods, which are the ones that need > special handling. Furthermore, we could refactor the current OracleFileSystem > and break it into two clases, one of them to keep the current behavior and a > new one to keep the common code (which we could rename to > OracleBaseFileSystem or similar, to maintain compatiblity with code that uses > OracleFileSystem for versions previous to 10.2). Then we make the > Oracle10FileSystem inherit from the latter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.