[ 
https://issues.apache.org/jira/browse/JCR-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868224#action_12868224
 ] 

Stefan Guggisberg commented on JCR-2625:
----------------------------------------

> Looks good to me. Do the davex integration tests still pass with the patch 
> applied? 

yes 

> Furthermore, did you check the impact of the StringCache on memory and 
> performance? There is a similar mechanism in place already for 
> NameFactoryImpl which works on Name instances instead of Strings.

the StringCache drastically reduces the number of (redundant) String instances, 
thereby reducing memory consumption.  
i didn't notice any negative impact on performance.  


> spi2davex: reduce memory footprint of Node/PropertyInfoImpl
> -----------------------------------------------------------
>
>                 Key: JCR-2625
>                 URL: https://issues.apache.org/jira/browse/JCR-2625
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-spi-commons, jackrabbit-spi2dav
>            Reporter: Stefan Guggisberg
>            Priority: Minor
>         Attachments: leaner_item_info_objects.patch
>
>
> the in-memory footprint of o.a.jackrabbit.spi2davex.NodeinfoImpl & 
> PropertyInfoImp is quite big. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to