[ 
https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131476#comment-13131476
 ] 

Alex Parvulescu commented on JCR-3117:
--------------------------------------

Hi Jukka,

can you be a bit more specific? I'm not sure what you want to replace with the 
TimeSeries:

> Statistics for the PersistenceManager impl that cover: 
>  - bundle cache access count, 
>  - bundle cache miss count, 
>  - bundle cache miss avg duration (this avg includes the penalty of having to 
> load from the underlying storage / can be interpreted as avg read latency as 
> there is no cache involved) 
>  - bundle writes per second 

Out of all the stats provided here, I'd say the 'bundle writes per second' fall 
into the TimeSeries scope. And there, I don't mind replacing the mechanism. 
As for the rest: 
 - the 2 counts are just incremental operations on AtomicLong, I don't really 
see the added value in using TS; 
 - the 'cache miss avg duration' : AFAIK the TS impl does not do averages 
currently, if it will, I'm open for using it.

                
> Stats for the PersistenceManager
> --------------------------------
>
>                 Key: JCR-3117
>                 URL: https://issues.apache.org/jira/browse/JCR-3117
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: jackrabbit-core
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>            Priority: Minor
>             Fix For: 2.3.2
>
>         Attachments: JCR-3117.patch
>
>
> Statistics for the PersistenceManager impl that cover: 
>  - bundle cache access count, 
>  - bundle cache miss count, 
>  - bundle cache miss avg duration (this avg includes the penalty of having to 
> load from the underlying storage / can be interpreted as avg read latency as 
> there is no cache involved) 
>  - bundle writes per second
> What it doesn't cover is :
>  - number of bundles
>  - size of workspace
> as these are values that are expensive to compute on demand, and caching them 
> would imply being able to store the values (which is not possible currently).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to