[ 
https://issues.apache.org/jira/browse/JCR-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134830#comment-13134830
 ] 

angela commented on JCR-3125:
-----------------------------

hi timothee, i think your patch is not complete:

- if you modify the spi2dav service constructor you need to adjust the one in 
spi2davex.
- please make sure you adjust javadoc links as well
- test case(s) would be cool as well

then on a more general level: we keep adding configuration options for the 
connection manager and
thus modifying the constructor.... maybe it would make sense to have 
constructor variant with a
map passing the connection manager configuration. since we alreay define 
constants for the
options in the factory we could use those.... what do yo think?

                
> Spi2davRepositoryServiceFactory#createRepositoryService() may hang forever if 
> using https scheme
> ------------------------------------------------------------------------------------------------
>
>                 Key: JCR-3125
>                 URL: https://issues.apache.org/jira/browse/JCR-3125
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi2dav
>    Affects Versions: 2.3.1
>            Reporter: Timothee Maret
>         Attachments: JCR-3125.patch
>
>
> Using a JcrUtils.REPOSITORY_URI parameter with HTTPS scheme (eg. 
> https://localhost:8080) when getting a repository instance out of 
> Jcr2davRepositoryFactory, may never return.
> In order to reproduce this, try to get a repository instance out of a server 
> that serves on http only.
> This could be fixed by allowing to set the connection and socket timeout on 
> the HTTP connection manager.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to