Mete Atamel created JCR-3303:
--------------------------------

             Summary: ClusterNode's stopDelay should default to something other 
zero
                 Key: JCR-3303
                 URL: https://issues.apache.org/jira/browse/JCR-3303
             Project: Jackrabbit Content Repository
          Issue Type: Bug
          Components: jackrabbit-core
            Reporter: Mete Atamel
            Priority: Minor


ClusterNode has a stopDelay that defaults to zero. This is problematic because 
it's used in joining syncThread. SyncThread is supposed to be a daemon thread 
which means it's not supposed to block JVM shutdown. However, by joining 
syncThread with a default stopDelay of zero, ClusterNode can potentially wait 
for syncThread to finish its job forever. This effectively makes syncThread a 
non-daemon thread and that can definitely make ClusterNode#stop block forever 
if syncThread never finishes.

Instead of defaulting to zero, I think it'd be better if stopDelay defaulted to 
something more reasonable like 2 * syncDelay. There's no need to make 
ClusterNode block forever for sync in any case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to