[ 
https://issues.apache.org/jira/browse/JCR-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293422#comment-13293422
 ] 

angela commented on JCR-3335:
-----------------------------

while i like the general approach of separating cache reading from writing i am 
not convinced that the patch would work as you replace 
the 'updateCache' method with 'getEntries'.

@julian: i am not aware of such tests. i created some tests to assert that the 
cache is properly cleared upon ac-modification... maybe we can
add tests for multithreaded access there?
                
> Reduce synchronized block scope when loading a node by id
> ---------------------------------------------------------
>
>                 Key: JCR-3335
>                 URL: https://issues.apache.org/jira/browse/JCR-3335
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>            Reporter: Alex Parvulescu
>         Attachments: CachingEntryCollector.java.patch
>
>
> This is a small(ish) change that takes the 'getNodeById' cll outside of the 
> synchronized block that wraps the cache access.
> I see the load call as a heavy one, and the proposed change offers better 
> concurrency behavior.
> In the tests that I ran, mostly related to queries I got a 20% improvement on 
> average query response time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to