[ 
https://issues.apache.org/jira/browse/JCR-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449795#comment-13449795
 ] 

Michael Dürig commented on JCR-3420:
------------------------------------

The patch looks quite good to me. 

> 1. Introducing new attribute 'factoryType'...
Is this really necessary? Shouldn't a custom factory just delegate to its 
predecessor? I.e. when you do parser.setBeanFactory(beanFactory) couldn't that 
register the new factory in a way such that when it can't create an instance it 
would automatically delegate instance creation to the previous factory? 
Otherwise, 'factoryClass' instead of 'factoryType' might be an option. That way 
there is no need to invent additional "type names" for the factory. 

> 2. We should maybe leave this out of the initial patch until it is used. 

> 3. and 4. 
We can address those separately as we go. For now I think this is a good start.
                
> Improving Jackrabbit integration within OSGi and other managed environment
> --------------------------------------------------------------------------
>
>                 Key: JCR-3420
>                 URL: https://issues.apache.org/jira/browse/JCR-3420
>             Project: Jackrabbit Content Repository
>          Issue Type: New Feature
>          Components: config, jackrabbit-core
>    Affects Versions: 2.5.1
>            Reporter: Michael Dürig
>         Attachments: JCR-3420-osgi-factory.patch
>
>
> While using jackrabbit in managed environment like Sling, Spring etc
> its easy for other components to access the Repository service.
> However its tricky to use managed components of those env within
> Jackrabbit as it creates the instances on its own. To simplify such
> integration it would be helpful if JR exposes a factory service which
> is used to create the various beans from the JR configuration.
> See http://markmail.org/message/johbo2dnepwtjogm for Chetan's initial 
> proposal and POC implementation. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to